lkml.org 
[lkml]   [2019]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 0/7] mm: Page fault enhancements
On Thu, Sep 5, 2019 at 3:15 AM Peter Xu <peterx@redhat.com> wrote:
>
> This series is split out of userfaultfd-wp series to only cover the
> general page fault changes, since it seems to make sense itself.

The series continues to look sane to me, but I'd like VM people to
take a look. I see a few reviewed-by's, it would be nice to see more
comments from people. I'd like to see Andrea in particular say "yeah,
this looks all good to me".

Also a question on how this will get to me - it smells like Andrew's
-mm tree to me, both from a VM and a userfaultfd angle (and looking
around, at least a couple of previous patches by Peter have gone that
way).

And it would be lovely to have actual _numbers_ for the alleged
latency improvements. I 100% believe them, but still, numbers rule.

Talking about latency, what about that retry loop in gup()? That's the
one I'm not at all convinced about. It doesn't check for signals, so
if there is some retry logic, it loops forever. Hmm?

Linus

\
 
 \ /
  Last update: 2019-09-05 23:12    [W:0.069 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site