[lkml]   [2019]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 2/6] lib/zstd/mem.h: replace __inline by inline
On Thu, Sep 5, 2019 at 2:00 AM Nick Desaulniers <> wrote:
> While you're here, would you mind replacing `__attribute__((unused))`
> with `__unused`? I would consider "naked attributes" (haven't been
> feature tested in include/linux/compiler_attributes.h and are verbose)
> to be an antipattern.

+1 We should aim to avoid them entirely where possible.

We have __always_unused and __maybe_unused, please choose whatever
fits best (both map to "unused", we don't have __unused).


 \ /
  Last update: 2019-09-05 02:09    [W:0.144 / U:2.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site