lkml.org 
[lkml]   [2019]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 1/4] ftrace: Implement fs notification for tracing_max_latency
From
Date
On 9/4/19 1:39 PM, Steven Rostedt wrote:
> On Tue, 3 Sep 2019 15:25:59 +0200
> Viktor Rosendahl <viktor.rosendahl@gmail.com> wrote:
>
>> +void latency_fsnotify_stop(void)
>> +{
>> + /* Make sure all CPUs see caller's previous actions to stop tracer */
>> + smp_wmb();
>
> These memory barriers just look wrong. What exactly are you trying to protect here?
>
> Where's the matching rmbs?
>

Thanks for reviewing.

However, since these functions will disappear when I take the irq_work
facility into use, we should perhaps not spend too much time discussing
what would have been.

There are no matching rmbs, I was thinking that the smp_wmb() would
merely enforce the order of the memory writes, as seen by other CPUs, so
that the tracer would be stopped, before the latency fsnotify is disabled.

E.g. in case of the preemptirqsoff tracer the idea was that it doesn't
matter exactly when a CPU sees the "tracer_enabled = 0;" in
stop_irqsoff_tracer() but that it needs to be seen before the writes in
latency_fsnotify_stop() are seen.

best regards,

Viktor

\
 
 \ /
  Last update: 2019-09-04 21:01    [W:0.089 / U:1.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site