Messages in this thread |  | | Subject | Re: [alsa-devel] [PATCH] soundwire: bus: set initial value to port_status | From | Pierre-Louis Bossart <> | Date | Tue, 3 Sep 2019 08:54:37 -0500 |
| |
On 8/29/19 1:11 PM, Bard liao wrote: > From: Bard Liao <yung-chuan.liao@linux.intel.com> > > port_status[port_num] are assigned for each port_num in some if > conditions. So some of the port_status may not be initialized.
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> > --- > drivers/soundwire/bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c > index f6a1e4b4813d..33f41b3e642e 100644 > --- a/drivers/soundwire/bus.c > +++ b/drivers/soundwire/bus.c > @@ -835,7 +835,7 @@ static int sdw_handle_port_interrupt(struct sdw_slave *slave, > static int sdw_handle_slave_alerts(struct sdw_slave *slave) > { > struct sdw_slave_intr_status slave_intr; > - u8 clear = 0, bit, port_status[15]; > + u8 clear = 0, bit, port_status[15] = {0}; > int port_num, stat, ret, count = 0; > unsigned long port; > bool slave_notify = false; >
|  |