lkml.org 
[lkml]   [2019]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 00/13] virtio-fs: shared file system for virtual machines
On Tue, Sep 3, 2019 at 10:31 AM Michael S. Tsirkin <mst@redhat.com> wrote:

> Can the patches themselves be posted to the relevant list(s) please?
> If possible, please also include "v3" in all patches so they are
> easier to find.

I'll post a v4.

> I poked at
> https://lwn.net/ml/linux-kernel/20190821173742.24574-1-vgoyal@redhat.com/
> specifically
> https://lwn.net/ml/linux-kernel/20190821173742.24574-12-vgoyal@redhat.com/
> and things like:
> + /* TODO lock */
> give me pause.
>
> Cleanup generally seems broken to me - what pauses the FS
>
> What about the rest of TODOs in that file?

AFAICS, some of those are QOI issues, and some are long term
performance items. I see no blockers or things that would pose a
security concern.

That said, it would be nice to get rid of them at some point.

> use of usleep is hacky - can't we do better e.g. with a
> completion?

Yes. I have a different implementation, but was planning to leave
this one in until the dust settles.

> Some typos - e.g. "reuests".

Fixed.

> > > fs/fuse/Kconfig | 11 +
> > > fs/fuse/Makefile | 1 +
> > > fs/fuse/control.c | 4 +-
> > > fs/fuse/cuse.c | 4 +-
> > > fs/fuse/dev.c | 89 ++-
> > > fs/fuse/dir.c | 26 +-
> > > fs/fuse/file.c | 15 +-
> > > fs/fuse/fuse_i.h | 120 +++-
> > > fs/fuse/inode.c | 203 +++---
> > > fs/fuse/virtio_fs.c | 1061 +++++++++++++++++++++++++++++++
> > > fs/splice.c | 3 +-
> > > include/linux/fs.h | 2 +
> > > include/uapi/linux/virtio_fs.h | 41 ++
> > > include/uapi/linux/virtio_ids.h | 1 +
> > > init/do_mounts.c | 10 +
> > > 15 files changed, 1462 insertions(+), 129 deletions(-)
> > > create mode 100644 fs/fuse/virtio_fs.c
> > > create mode 100644 include/uapi/linux/virtio_fs.h
>
> Don't the new files need a MAINTAINERS entry?
> I think we want virtualization@lists.linux-foundation.org to be
> copied.

Yep.

Stefan, do you want to formally maintain this file?

Thanks,
Miklos

\
 
 \ /
  Last update: 2019-09-03 11:18    [W:0.120 / U:1.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site