lkml.org 
[lkml]   [2019]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arm64: dts: rockchip: Fix usb-c on Hugsun X99 TV Box
On Sun, Sep 29, 2019 at 01:22:17PM +0200, Vicente Bergas wrote:
> On Sunday, September 29, 2019 5:22:30 AM CEST, Vivek Unune wrote:
> > Fix usb-c on X99 TV Box. Tested with armbian w/ kernel 5.3
> >
> > Signed-off-by: Vivek Unune <npcomplete13@gmail.com>
> > ---
> > arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > index 0d1f5f9a0de9..c133e8d64b2a 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-hugsun-x99.dts
> > @@ -644,7 +644,7 @@
> > status = "okay";
> > u2phy0_host: host-port {
> > - phy-supply = <&vcc5v0_host>;
> > + phy-supply = <&vcc5v0_typec>;
> > status = "okay";
> > };
> > @@ -712,7 +712,7 @@
> > &usbdrd_dwc3_0 {
> > status = "okay";
> > - dr_mode = "otg";
> > + dr_mode = "host";
> > };
> > &usbdrd3_1 {
>
> Hi Vivek,
>
> which is the relationship of your patch and this commit:
>
> e1d9149e8389f1690cdd4e4056766dd26488a0fe
> arm64: dts: rockchip: Fix USB3 Type-C on rk3399-sapphire
>
> with respect to this other commit:
>
> c09b73cfac2a9317f1104169045c519c6021aa1d
> usb: dwc3: don't set gadget->is_otg flag
>
> ?
>
> I did not test reverting e1d9149e since c09b73cf was applied.
>
> Regards,
> Vicenç.
>

Hi Vicenç,

Indeed, I was motivated by e1d9149e ("arm64: dts: rockchip: Fix USB3
Type-C on rk3399-sapphire"). X99 TV box showed exact same symptoms
with usb-c port. After applying the fix, it worked.

I was not aware of c09b73cf ("usb: dwc3: don't set gadget->is_otg
flag") and it will be interesting to test it. This might render
my fix unecessary.

Thanks,

Vivek

\
 
 \ /
  Last update: 2019-09-30 01:47    [W:0.118 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site