[lkml]   [2019]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] jffs2: Fix mounting under new mount API

On 26.09.2019 17:21, David Howells wrote:

> The mounting of jffs2 is broken due to the changes from the new mount API
> because it specifies a "source" operation, but then doesn't actually
> process it. But because it specified it, it doesn't return -ENOPARAM and

What specified what? Too many "it"'s to figure that out. :-)

> the caller doesn't process it either and the source gets lost.
> Fix this by simply removing the source parameter from jffs2 and letting the
> VFS deal with it in the default manner.
> To test it, enable CONFIG_MTD_MTDRAM and allow the default size and erase
> block size parameters, then try and mount the /dev/mtdblock<N> file that
> that creates as jffs2. No need to initialise it.

One "that" should be enough. :-)

> Fixes: ec10a24f10c8 ("vfs: Convert jffs2 to use the new mount API")
> Reported-by: Al Viro <>
> Signed-off-by: David Howells <>
> cc: David Woodhouse <>
> cc: Richard Weinberger <>
> cc:

MBR, Sergei

 \ /
  Last update: 2019-09-27 10:39    [W:0.113 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site