lkml.org 
[lkml]   [2019]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] riscv: resolve most warnings from sparse
On Thu, Sep 19, 2019 at 10:31:42AM -0700, Christoph Hellwig wrote:
> On Thu, Sep 19, 2019 at 01:26:38AM -0700, Paul Walmsley wrote:
> >
> > Resolve most of the warnings emitted by sparse. The objective here is
> > to keep arch/riscv as clean as possible with regards to sparse warnings,
> > and to maintain this bar for subsequent patches.
>
> I think this patch does just way to many different things and needs
> to be split up into one patch per issue / code module.
>
> > --- /dev/null
> > +++ b/arch/riscv/include/asm/entry.h
>
> For example adding this file should be a patch on its own. It can
> also move to arch/riscv/kernel/ instead of polluting the <asm/*.h>
> namespace. That being said I'm not sure I like this and the
> head.h patches. Just adding a header for entry points used from
> aseembly only seems rather pointless, I wonder if there is a way
> to just shut up sparse on them. Same for most of head.h.

The pseudo-specifier '__visible' (for __attribute__((__externally_visible__)))
is defined for this.

Best regards,
-- Luc Van Oostenryck

\
 
 \ /
  Last update: 2019-09-26 23:30    [W:0.075 / U:2.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site