lkml.org 
[lkml]   [2019]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing: Fix clang -Wint-in-bool-context warnings in IF_ASSIGN macro
On Thu, 26 Sep 2019 01:37:29 +0200
Dávid Bolvanský <david.bolvansky@gmail.com> wrote:

> GCC C frontend does not warn, GCC C++ FE does. https://godbolt.org/z/_sczyM
>
> So I (we?) think there is something weird in gcc frontends.
>
> >> I can't think of a case that this warning is a bug (maybe David can
> explain more),
>
> In this case or generally? General bug example:
>
> if (state == A || B)
>
> (should be if (state == A || state == B))
>
> Since this is just one occurrence and I recommend to just land this small
> fix.
>

Can we add the above comment to the commit log. I was stuck on
wondering what was wrong with the original code, and was ignoring the
patch because I couldn't see what was wrong.

-- Steve

\
 
 \ /
  Last update: 2019-09-26 14:15    [W:0.033 / U:1.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site