lkml.org 
[lkml]   [2019]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] iio: imu: adis16480: clean up a condition
Date
On Thu, 2019-09-26 at 11:10 +0300, Dan Carpenter wrote:
> [External]
>
> The "t" variable is unsigned so it can't be less than zero. We really
> are just trying to prevent divide by zero bugs so just checking against
> zero is sufficient.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/iio/imu/adis16480.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
> index b99d73887c9f..e144e567675d 100644
> --- a/drivers/iio/imu/adis16480.c
> +++ b/drivers/iio/imu/adis16480.c
> @@ -318,7 +318,7 @@ static int adis16480_set_freq(struct iio_dev
> *indio_dev, int val, int val2)
> unsigned int t, reg;

I would just change the type of "t" to "int".
Especially, since "val" & "val2" are "int".

Thanks for the catch :)
Alex

>
> t = val * 1000 + val2 / 1000;
> - if (t <= 0)
> + if (t == 0)
> return -EINVAL;
>
> /*
\
 
 \ /
  Last update: 2019-09-26 13:07    [W:0.068 / U:2.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site