lkml.org 
[lkml]   [2019]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/4] arm64: vdso32: Fix compilation warning
From
Date
On 9/26/19 9:32 AM, Catalin Marinas wrote:
> On Thu, Sep 26, 2019 at 07:03:52AM +0100, Vincenzo Frascino wrote:
>> diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h
>> index b61b50bf68b1..b1c8c43234c5 100644
>> --- a/arch/arm64/include/asm/memory.h
>> +++ b/arch/arm64/include/asm/memory.h
>> @@ -228,11 +228,16 @@ static inline unsigned long kaslr_offset(void)
>> #define __tag_get(addr) 0
>> #endif /* CONFIG_KASAN_SW_TAGS */
>>
>> +#ifdef __aarch64__
>> static inline const void *__tag_set(const void *addr, u8 tag)
>> {
>> u64 __addr = (u64)addr & ~__tag_shifted(0xff);
>> return (const void *)(__addr | __tag_shifted(tag));
>> }
>> +#else
>> +/* Unused in 32 bit mode */
>> +#define __tag_set(addr, tag) 0
>> +#endif
>
> I'm fine with this as a temporary workaround (or hack). But please add a
> better comment on what the 32-bit mode is about - the compat vDSO.
>

Ok, I will do in v2, to avoid confusion.

--
Regards,
Vincenzo

\
 
 \ /
  Last update: 2019-09-26 13:03    [W:0.094 / U:4.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site