lkml.org 
[lkml]   [2019]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] KVM: LAPIC: Loose fluctuation filter for auto tune lapic_timer_advance_ns
On Thu, 26 Sep 2019 at 18:25, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 26/09/19 02:54, Wanpeng Li wrote:
> > -#define LAPIC_TIMER_ADVANCE_ADJUST_MIN 100
> > -#define LAPIC_TIMER_ADVANCE_ADJUST_MAX 5000
> > -#define LAPIC_TIMER_ADVANCE_ADJUST_INIT 1000
> > +#define LAPIC_TIMER_ADVANCE_EXPIRE_MIN 100
> > +#define LAPIC_TIMER_ADVANCE_EXPIRE_MAX 10000
> > +#define LAPIC_TIMER_ADVANCE_NS_INIT 1000
> > +#define LAPIC_TIMER_ADVANCE_NS_MAX 5000
>
> I think the old #define value is good. What about:
>
> -#define LAPIC_TIMER_ADVANCE_ADJUST_MIN 100
> -#define LAPIC_TIMER_ADVANCE_ADJUST_MAX 5000
> -#define LAPIC_TIMER_ADVANCE_ADJUST_INIT 1000
> +#define LAPIC_TIMER_ADVANCE_ADJUST_MIN 100 /* clock cycles */
> +#define LAPIC_TIMER_ADVANCE_ADJUST_MAX 10000 /* clock cycles */
> +#define LAPIC_TIMER_ADVANCE_NS_INIT 1000
> +#define LAPIC_TIMER_ADVANCE_NS_MAX 5000

Looks good, I guess you can update the patch during apply. :)

Wanpeng

\
 
 \ /
  Last update: 2019-09-26 12:35    [W:0.053 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site