lkml.org 
[lkml]   [2019]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/4] kgdb: Remove unused DCPU_SSTEP definition
From
Date
On 9/25/19 3:02 PM, Douglas Anderson wrote:
> From doing a 'git log --patch kernel/debug', it looks as if DCPU_SSTEP
> has never been used. Presumably it used to be used back when kgdb was
> out of tree and nobody thought to delete the definition when the usage
> went away. Delete.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

The history on this one is that it was part of the logic for the soft stepping on ARM v5 cores. The code was never merged to the mainline for doing this, so the .h definition can certainly go.

Acked-by: Jason Wessel <jason.wessel@windriver.com>

> ---
>
> Changes in v3:
> - Patch ("Remove unused DCPU_SSTEP definition") new for v3.
>
> Changes in v2: None
>
> kernel/debug/debug_core.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/debug/debug_core.h b/kernel/debug/debug_core.h
> index b4a7c326d546..804b0fe5a0ba 100644
> --- a/kernel/debug/debug_core.h
> +++ b/kernel/debug/debug_core.h
> @@ -33,7 +33,6 @@ struct kgdb_state {
> #define DCPU_WANT_MASTER 0x1 /* Waiting to become a master kgdb cpu */
> #define DCPU_NEXT_MASTER 0x2 /* Transition from one master cpu to another */
> #define DCPU_IS_SLAVE 0x4 /* Slave cpu enter exception */
> -#define DCPU_SSTEP 0x8 /* CPU is single stepping */
>
> struct debuggerinfo_struct {
> void *debuggerinfo;
>

\
 
 \ /
  Last update: 2019-09-25 22:10    [W:0.088 / U:15.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site