lkml.org 
[lkml]   [2019]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 18/27] drm/dp_mst: Remove lies in {up,down}_rep_recv documentation
On Tue, Sep 03, 2019 at 04:45:56PM -0400, Lyude Paul wrote:
> These are most certainly accessed from far more than the mgr work. In
> fact, up_req_recv is -only- ever accessed from outside the mgr work.
>
> Cc: Juston Li <juston.li@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Harry Wentland <hwentlan@amd.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Lyude Paul <lyude@redhat.com>

Reviewed-by: Sean Paul <sean@poorly.run>

> ---
> include/drm/drm_dp_mst_helper.h | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h
> index f253ee43e9d9..8ba2a01324bb 100644
> --- a/include/drm/drm_dp_mst_helper.h
> +++ b/include/drm/drm_dp_mst_helper.h
> @@ -489,15 +489,11 @@ struct drm_dp_mst_topology_mgr {
> int conn_base_id;
>
> /**
> - * @down_rep_recv: Message receiver state for down replies. This and
> - * @up_req_recv are only ever access from the work item, which is
> - * serialised.
> + * @down_rep_recv: Message receiver state for down replies.
> */
> struct drm_dp_sideband_msg_rx down_rep_recv;
> /**
> - * @up_req_recv: Message receiver state for up requests. This and
> - * @down_rep_recv are only ever access from the work item, which is
> - * serialised.
> + * @up_req_recv: Message receiver state for up requests.
> */
> struct drm_dp_sideband_msg_rx up_req_recv;
>
> --
> 2.21.0
>

--
Sean Paul, Software Engineer, Google / Chromium OS

\
 
 \ /
  Last update: 2019-09-25 21:33    [W:0.032 / U:6.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site