lkml.org 
[lkml]   [2019]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] selftests: kvm: Fix libkvm build error
From
Date
On 9/25/19 1:48 AM, Paolo Bonzini wrote:
> On 24/09/19 22:14, Shuah Khan wrote:
>> Fix the following build error:
>>
>> libkvm.a(assert.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a PIE object; recompile with -fPIC
>>
>> Add -fPIC to CFLAGS to fix it.
>
> This is wrong, these testcases cannot be position-independent
> executables. Can you include the failing command line from "V=1"
> output?
>

You are right. This isn't correct.

> The problem seems to be that these definitions are not working properly:
>
> no-pie-option := $(call try-run, echo 'int main() { return 0; }' | \
> $(CC) -Werror $(KBUILD_CPPFLAGS) $(CC_OPTION_CFLAGS) -no-pie -x c - -o "$$TMP", -no-pie)
>
> LDFLAGS += -pthread $(no-pie-option)
>

Yup. That is what is happening, when I build using

"make TARGETS=kvm kselftest"

You can see this below:

gcc -Wall -Wstrict-prototypes -Wuninitialized -O2 -g -std=gnu99
-fno-stack-protector -fno-PIE -I../../../../tools/include
-I../../../../usr/include/ -Iinclude -Ix86_64 -Iinclude/x86_64 -I..
-pthread x86_64/cr4_cpuid_sync_test.c


vs.

Running make in kvm directory:

gcc -Wall -Wstrict-prototypes -Wuninitialized -O2 -g -std=gnu99
-fno-stack-protector -fPIC -fno-PIE -I../../../../tools/include
-I../../../../usr/include/ -Iinclude -Ix86_64 -Iinclude/x86_64 -I..
-pthread -no-pie x86_64/cr4_cpuid_sync_test.c

I was playing with both options yesterday and totally confused myself
thinking that adding fPIC helps. It doesn't.

I am looking into this to see how we can make "make kselftest" work.
Once I figure it out, will send v2. I think for some reason in the
failing case, no-pie-option and pgste-option are null strings.

thanks,
-- Shuah

\
 
 \ /
  Last update: 2019-09-25 18:48    [W:0.046 / U:0.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site