lkml.org 
[lkml]   [2019]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 2/2] misc: xilinx_flex: Add support for the flex noc Performance Monitor
On Wed, Sep 25, 2019 at 04:53:07PM +0530, Shubhrajyoti Datta wrote:
> Add support for the FlexNoc Performance Monitor.
> Adds support for various port setting and monitoring
> the packets transactions. It supports LPD and FPD monitoring
> counters for read and write transaction requests and responses.
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
> drivers/misc/Kconfig | 9 +
> drivers/misc/Makefile | 1 +
> drivers/misc/xilinx_flex_pm.c | 644 ++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 654 insertions(+)
> create mode 100644 drivers/misc/xilinx_flex_pm.c

You are creating new sysfs files (in a buggy and racy way), and not
documenting them in Documentation/ABI/ which is not allowed.

Please fix up both issues before resending.

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-09-25 13:30    [W:0.047 / U:2.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site