lkml.org 
[lkml]   [2019]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] tpm: only set efi_tpm_final_log_size after successful event log parsing
On Mon, Sep 23, 2019 at 10:10:10AM -0700, Jerry Snitselaar wrote:
> Any thoughts on this? I know of at least 2 Lenovo models that are
> running into this problem.
>
> In the case of the one I have currently have access to the problem is
> that the hash algorithm id for an event isn't one that is currently in
> the TCG registry, and it fails to find a match when walking the
> digest_sizes array. That seems like an issue for the vendor to fix in the bios,
> but we should look at the return value of tpm2_calc_event_log_size and not
> stick a negative value in efi_tpm_final_log_size.

Please use then "pr_err(FW_BUG".

Also, since you know the context you could add a comment along the
lines what you wrote.

/Jarkko

\
 
 \ /
  Last update: 2019-09-25 12:41    [W:0.453 / U:1.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site