lkml.org 
[lkml]   [2019]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH xfstests v3] overlay: Enable character device to be the base fs partition
On Wed, Sep 25, 2019 at 10:18:39AM +0300, Amir Goldstein wrote:
> On Wed, Sep 25, 2019 at 9:29 AM Zhihao Cheng <chengzhihao1@huawei.com> wrote:
> >
> > When running overlay tests using character devices as base fs partitions,
> > all overlay usecase results become 'notrun'. Function
> > '_overay_config_override' (common/config) detects that the current base
> > fs partition is not a block device and will set FSTYP to base fs. The
> > overlay usecase will check the current FSTYP, and if it is not 'overlay'
> > or 'generic', it will skip the execution.
> >
> > For example, using UBIFS as base fs skips all overlay usecases:
> >
> > FSTYP -- ubifs # FSTYP should be overridden as 'overlay'
> > MKFS_OPTIONS -- /dev/ubi0_1 # Character device
> > MOUNT_OPTIONS -- -t ubifs /dev/ubi0_1 /tmp/scratch
> >
> > overlay/001 [not run] not suitable for this filesystem type: ubifs
> > overlay/002 [not run] not suitable for this filesystem type: ubifs
> > overlay/003 [not run] not suitable for this filesystem type: ubifs
> >
> > When checking that the base fs partition is a block/character device,
> > FSTYP is overwritten as 'overlay'. This patch allows the base fs
> > partition to be a character device that can also execute overlay
> > usecases (such as ubifs).
> >
> > Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
>
> Looks fine.
> Eryu, you may change this to Reviewed-by

Sure, thanks for the review!

Eryu

\
 
 \ /
  Last update: 2019-09-25 11:29    [W:0.040 / U:3.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site