lkml.org 
[lkml]   [2019]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ACPICA: Introduce acpi_load_table_with_index()
On Tue, Sep 24, 2019 at 03:07:34PM +0300, Shevchenko, Andriy wrote:
> On Mon, Sep 23, 2019 at 11:47:01AM +0200, Nikolaus Voss wrote:
> > For unloading an ACPI table, it is necessary to provide the
> > index of the table. The method intended for dynamically
> > loading or hotplug addition of tables, acpi_load_table(),
> > does not provide this information, so a new function
> > acpi_load_table_with_index() with the same functionality,
> > but an optional pointer to the loaded table index is introduced.
> >
> > The new function is used in the acpi_configfs driver to save the
> > index of the newly loaded table in order to unload it later.
>
> I'll test it later, though couple of remarks:
> - would it make sense to provide a counter part helper for unloading? Now it
> looks a bit inconsistent in configfs when we use acpi_load_*() vs.
> acpi_tb_*() in remove.

...and I think we may unexport acpi_tb_* in this case as Bob suggested for it
to be internal API.

> - please, include Ferry into Cc (as done in this mail)


--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2019-09-24 14:09    [W:0.120 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site