lkml.org 
[lkml]   [2019]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 097/128] iommu/iova: Avoid false sharing on fq_timer_on
    Date
    From: Eric Dumazet <edumazet@google.com>

    [ Upstream commit 0d87308cca2c124f9bce02383f1d9632c9be89c4 ]

    In commit 14bd9a607f90 ("iommu/iova: Separate atomic variables
    to improve performance") Jinyu Qi identified that the atomic_cmpxchg()
    in queue_iova() was causing a performance loss and moved critical fields
    so that the false sharing would not impact them.

    However, avoiding the false sharing in the first place seems easy.
    We should attempt the atomic_cmpxchg() no more than 100 times
    per second. Adding an atomic_read() will keep the cache
    line mostly shared.

    This false sharing came with commit 9a005a800ae8
    ("iommu/iova: Add flush timer").

    Signed-off-by: Eric Dumazet <edumazet@google.com>
    Fixes: 9a005a800ae8 ('iommu/iova: Add flush timer')
    Cc: Jinyu Qi <jinyuqi@huawei.com>
    Cc: Joerg Roedel <jroedel@suse.de>
    Acked-by: Robin Murphy <robin.murphy@arm.com>
    Signed-off-by: Joerg Roedel <jroedel@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/iommu/iova.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c
    index 9a576ae837dcb..da4516fbf5425 100644
    --- a/drivers/iommu/iova.c
    +++ b/drivers/iommu/iova.c
    @@ -580,7 +580,9 @@ void queue_iova(struct iova_domain *iovad,

    spin_unlock_irqrestore(&fq->lock, flags);

    - if (atomic_cmpxchg(&iovad->fq_timer_on, 0, 1) == 0)
    + /* Avoid false sharing as much as possible. */
    + if (!atomic_read(&iovad->fq_timer_on) &&
    + !atomic_cmpxchg(&iovad->fq_timer_on, 0, 1))
    mod_timer(&iovad->fq_timer,
    jiffies + msecs_to_jiffies(IOVA_FQ_TIMEOUT));
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-09-22 21:16    [W:14.931 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site