lkml.org 
[lkml]   [2019]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT PULL] MIPS changes
On Sat, Sep 21, 2019 at 4:10 PM Paul Burton <paul.burton@mips.com> wrote:
>
> Here are the main MIPS changes for v5.4; please pull.

Hmm. I pulled and because initial tests didn't show any issues, I
already pushed out.

But some unrelated further testing then shows that this:

> Florian Fainelli (2):
> firmware: bcm47xx_nvram: Correct size_t printf format
> firmware: bcm47xx_nvram: Allow COMPILE_TEST

causes problems, and commit feb4eb060c3a ("firmware: bcm47xx_nvram:
Correct size_t printf format") is buggy:

drivers/firmware/broadcom/bcm47xx_nvram.c: In function ‘nvram_init’:
drivers/firmware/broadcom/bcm47xx_nvram.c:151: warning: format ‘%zu’
expects argument of type ‘size_t’, but argument 2 has type ‘u32’ {aka
‘unsigned int’} [-Wformat=]

and the change to use %zu was completely wrong.

It prints out 'header.len', which is an u32, not nvram_len which is a size_t.

Tssk tssk.

I've fixed it in my tree, but this should have shown up in linux-next,
or in MIPS testing. The process clearly failed.

Linus

\
 
 \ /
  Last update: 2019-09-22 20:36    [W:0.109 / U:1.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site