Messages in this thread Patch in this message |  | | From | Yizhuo <> | Subject | [PATCH] regulator: pfuze100-regulator: Variable "val" in pfuze100_regulator_probe() could be uninitialized | Date | Mon, 2 Sep 2019 15:10:47 -0700 |
| |
In function pfuze100_regulator_probe(), variable "val" could be initialized if regmap_read() fails. However, "val" is used to decide the control flow later in the if statement, which is potentially unsafe.
Signed-off-by: Yizhuo <yzhai003@ucr.edu> --- drivers/regulator/pfuze100-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c index df5df1c495ad..649e2bfcdffd 100644 --- a/drivers/regulator/pfuze100-regulator.c +++ b/drivers/regulator/pfuze100-regulator.c @@ -777,7 +777,7 @@ static int pfuze100_regulator_probe(struct i2c_client *client, for (i = 0; i < regulator_num; i++) { struct regulator_init_data *init_data; struct regulator_desc *desc; - int val; + int val = 0; desc = &pfuze_chip->regulator_descs[i].desc; -- 2.17.1
|  |