lkml.org 
[lkml]   [2019]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/9] added helper macros to remove duplicate code from probe functions of the platform drivers
On 15-09-19, 12:30, Satendra Singh Thakur wrote:
> 1. For most of the platform drivers's probe include following steps
>
> -memory allocation for driver's private structure
> -getting io resources
> -io remapping resources
> -getting irq number
> -registering irq
> -setting driver's private data
> -getting clock
> -preparing and enabling clock

And we have perfect set of APIs for these tasks!

> 2. We have defined a set of macros to combine some or all of
> the above mentioned steps. This will remove redundant/duplicate
> code in drivers' probe functions of platform drivers.

Why, how does it help and you do realize it also introduces bugs

> devm_platform_probe_helper(pdev, priv, clk_name);
> devm_platform_probe_helper_clk(pdev, priv, clk_name);
> devm_platform_probe_helper_irq(pdev, priv, clk_name,
> irq_hndlr, irq_flags, irq_name, irq_devid);
> devm_platform_probe_helper_all(pdev, priv, clk_name,
> irq_hndlr, irq_flags, irq_name, irq_devid);
> devm_platform_probe_helper_all_data(pdev, priv, clk_name,
> irq_hndlr, irq_flags, irq_name, irq_devid);
>
> 3. Code is made devres compatible (wherever required)
> The functions: clk_get, request_irq, kzalloc, platform_get_resource
> are replaced with their devm_* counterparts.

We already have devres APIs for people to use!
>
> 4. Few bugs are also fixed.

Which ones..?

>
> Satendra Singh Thakur (9):
> probe/dma : added helper macros to remove redundant/duplicate code
> from probe functions of the dma controller drivers
> probe/dma/jz4740: removed redundant code from jz4740 dma controller's
> probe function
> probe/dma/zx: removed redundant code from zx dma controller's probe
> function
> probe/dma/qcom-bam: removed redundant code from qcom bam dma
> controller's probe function
> probe/dma/mtk-hs: removed redundant code from mediatek hs dma
> controller's probe function
> probe/dma/sun6i: removed redundant code from sun6i dma controller's
> probe function
> probe/dma/sun4i: removed redundant code from sun4i dma controller's
> probe function
> probe/dma/axi: removed redundant code from axi dma controller's probe
> function
> probe/dma/owl: removed redundant code from owl dma controller's probe
> function
>
> drivers/dma/dma-axi-dmac.c | 28 ++---
> drivers/dma/dma-jz4740.c | 33 +++---
> drivers/dma/mediatek/mtk-hsdma.c | 38 +++----
> drivers/dma/owl-dma.c | 29 ++---
> drivers/dma/qcom/bam_dma.c | 71 +++++-------
> drivers/dma/sun4i-dma.c | 30 ++----
> drivers/dma/sun6i-dma.c | 30 ++----
> drivers/dma/zx_dma.c | 35 ++----
> include/linux/probe-helper.h | 179 +++++++++++++++++++++++++++++++
> 9 files changed, 280 insertions(+), 193 deletions(-)
> create mode 100644 include/linux/probe-helper.h
>
> --
> 2.17.1

--
~Vinod

\
 
 \ /
  Last update: 2019-09-18 12:29    [W:0.172 / U:2.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site