lkml.org 
[lkml]   [2019]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: r8188eu: replace rtw_malloc() with it's definition
From
Date
On 9/10/19 2:59 PM, Dan Carpenter wrote:
> On Sun, Sep 08, 2019 at 12:00:26PM +0300, Ivan Safonov wrote >> rtw_malloc prevents the use of kmemdup/kzalloc and others.
>>
>> Signed-off-by: Ivan Safonov <insafonov@gmail.com>
>> ---
>> drivers/staging/rtl8188eu/core/rtw_ap.c | 4 ++--
>> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +-
>> .../staging/rtl8188eu/include/osdep_service.h | 3 ---
>> drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 18 +++++++++---------
>> drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 2 +-
>> .../staging/rtl8188eu/os_dep/osdep_service.c | 7 +------
>> 6 files changed, 14 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
>> index 51a5b71f8c25..c9c57379b7a2 100644
>> --- a/drivers/staging/rtl8188eu/core/rtw_ap.c
>> +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
>> @@ -104,7 +104,7 @@ static void update_BCNTIM(struct adapter *padapter)
>> }
>>
>> if (remainder_ielen > 0) {
>> - pbackup_remainder_ie = rtw_malloc(remainder_ielen);
>> + pbackup_remainder_ie = kmalloc(remainder_ielen, in_interrupt() ? GFP_ATOMIC : GFP_KERNEL);
> ^^^^^^^^^^^^^
> This stuff isn't right. It really should be checking if spinlocks are
> held or IRQs are disabled. And the only way to do that is by auditing
> the callers.
I hope to make these changes later as separate independent patches.
This patch do only one thing - remove rtw_malloc().

>
> (The original rtw_malloc() implementation is buggy nonsense).
>
> regards,
> dan carpenter
>

Ivan Safonov.

\
 
 \ /
  Last update: 2019-09-14 17:15    [W:0.060 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site