lkml.org 
[lkml]   [2019]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch: Warn if DT bindings are not in schema format
From
Date
On Fri, 2019-09-13 at 16:13 -0500, Rob Herring wrote:
> DT bindings are moving to using a json-schema based schema format
> instead of freeform text. Add a checkpatch.pl check to encourage using
> the schema for new bindings. It's not yet a requirement, but is
> progressively being required by some maintainers.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2822,6 +2822,14 @@ sub process {
> "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);
> }
>
> +# Check for adding new DT bindings not in schema format
> + if (!$in_commit_log &&
> + ($line =~ /^new file mode\s*\d+\s*$/) &&
> + ($realfile =~ m@^Documentation/devicetree/bindings/.*\.txt$@)) {
> + WARN("DT_SCHEMA_BINDING_PATCH",
> + "DT bindings should be in DT schema format. See: Documentation/devicetree/writing-schema.rst\n");
> + }
> +

As this already seems to be git dependent, perhaps
it's easier to read with a single line test like:

if ($line =~ m{^\s*create mode\s*\d+\s*Documentation/devicetree/bindings/.*\.txt$}) {
etc...
}

There are ~3500 existing .txt files:

$ git ls-files -- 'Documentation/devicetree/bindings/*.txt' | wc -l
3476

Are these going to be converted somehow?

What about files like these? (not .txt)

Documentation/devicetree/bindings/timer/st,stih407-lpc
Documentation/devicetree/bindings/nds32/andestech-boards
Documentation/devicetree/bindings/media/nokia,n900-ir
Documentation/devicetree/bindings/interrupt-controller/ti,omap4-wugen-mpu
Documentation/devicetree/bindings/arm/cpu-enable-method/nuvoton,npcm750-smp
Documentation/devicetree/bindings/arm/cpu-enable-method/marvell,berlin-smp
Documentation/devicetree/bindings/arm/cpu-enable-method/al,alpine-smp
Documentation/devicetree/bindings/arm/arm-boards



\
 
 \ /
  Last update: 2019-09-13 23:49    [W:0.064 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site