[lkml]   [2019]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH 0/7] Address most issues when building with W=1
There is a recent discussion at KS ML with regards to use W=1 as default.

No idea if this will happen or not, but it doesn't hurt cleaning up W=1
warnings from the EDAC subsystem, specially since it helps to cleanup
a few things.

This patch series addresses most of such warnings. After this series,
there will be just two W=1 warnings:

1) i5100 EDAC driver:

drivers/edac/i5100_edac.c: In function ‘i5100_read_log’:
drivers/edac/i5100_edac.c:487:11: warning: variable ‘ecc_loc’ set but not used [-Wunused-but-set-variable]
487 | unsigned ecc_loc = 0;
| ^~~~~~~

The ecc_loc contents is filled from MC data, but it is not used anywere.
The i5100 MC is very old: the affected code was added in 2008. It should
probably be safe to just drop the corresponding data, but, as it may
contain some relevant info, I was a little reticent of doing that.

2) Xgene EDAC driver:

drivers/edac/xgene_edac.c: In function ‘xgene_edac_rb_report’:
drivers/edac/xgene_edac.c:1486:7: warning: variable ‘address’ set but not used [-Wunused-but-set-variable]
1486 | u32 address;
| ^~~~~~~

I suspect that the content of the address field should actually be used on
at least some of the logs.

I may eventually submit patches later to address the above cases, but let's
solve first the other cases, as they all sound trivial enough.

Mauro Carvalho Chehab (7):
EDAC: i5100_edac: get rid of an unused var
EDAC: i7300_edac: rename a kernel-doc var description
EDAC: i7300_edac: fix a kernel-doc syntax
EDAC: i5400_edac: print type at debug message
EDAC: i5400_edac: get rid of some unused vars
EDAC: sb_edac: get rid of unused vars
EDAC: skx_common: get rid of unused type var

drivers/edac/i5100_edac.c | 2 --
drivers/edac/i5400_edac.c | 15 +++------------
drivers/edac/i7300_edac.c | 4 ++--
drivers/edac/sb_edac.c | 21 ++++++++-------------
drivers/edac/skx_common.c | 5 +----
5 files changed, 14 insertions(+), 33 deletions(-)


 \ /
  Last update: 2019-09-13 16:51    [W:0.082 / U:4.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site