[lkml]   [2019]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/3] brcmsmac: Remove unneeded variable and make function to be void
zhong jiang <> wrote:

> brcms_c_set_mac do not need return value to cope with different
> cases. And change functon return type to void.
> Signed-off-by: zhong jiang <>

I just don't see the benefit from changing the function to return void.
And if we ever add error handling to the function we need to change it
back to return int again, which is extra work.

Patch set to Rejected.


 \ /
  Last update: 2019-09-13 15:38    [W:0.199 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site