lkml.org 
[lkml]   [2019]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tty: 8250_of: Use software emulated RS485 direction control
On Fri, Sep 13, 2019 at 07:01:05AM +0200, Heiko Schocher wrote:
> Use software emulated RS485 direction control to provide RS485 API
>
> Currently it is not possible to use rs485 as pointer to
> rs485_config struct in struct uart_port is NULL in case we
> configure the port through device tree.

Thank you for the patch, few recommendations for the future submissions.

> Patch is based on:
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> commit:
> 505a8ec7e11a - Revert "drm/i915/userptr: Acquire the page lock around set_page_dirty()"

More reliably is to base on corresponding subsystem tree, i.e. tty-next for
this case.

> checkpatch output:
> $ ./scripts/checkpatch.pl 0001-tty-8250_of-Use-software-emulated-RS485-direction-co.patch
> total: 0 errors, 0 warnings, 43 lines checked
>
> 0001-tty-8250_of-Use-software-emulated-RS485-direction-co.patch has no obvious style problems and is ready for submission.

There is no need to mention this. It's supposed that submitter did that
themselves.

When you gather people to send the patch to, I recommend to use some threshold,
e.g. `scripts/get_maintainer.pl --git --git-min-percent=67 ...`

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2019-09-13 12:25    [W:0.069 / U:5.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site