lkml.org 
[lkml]   [2019]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Regression: commit c9712e333809 breaks xilinx_uartps
From
Date
On 12. 09. 19 18:38, Paul Thomas wrote:
>>> ---
>>> drivers/tty/serial/xilinx_uartps.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/tty/serial/xilinx_uartps.c
>>> b/drivers/tty/serial/xilinx_uartps.c
>>> index 9dcc4d855ddd..ece7f6caa994 100644
>>> --- a/drivers/tty/serial/xilinx_uartps.c
>>> +++ b/drivers/tty/serial/xilinx_uartps.c
>>> @@ -1565,6 +1565,8 @@ static int cdns_uart_probe(struct platform_device *pdev)
>>>
>>> cdns_uart_data->pclk = devm_clk_get(&pdev->dev, "pclk");
>>> if (PTR_ERR(cdns_uart_data->pclk) == -EPROBE_DEFER) {
>>> + /* If we end up defering then set uartps_major back to 0 */
>>> + uartps_major = 0;
>>> rc = PTR_ERR(cdns_uart_data->pclk);
>>> goto err_out_unregister_driver;
>>> }
>>>
>>
>> I expect that this can be problematic for all failures in probe.
>> What about this?
> Makes sense, this worked for me. Although, I think the patch is
> malformed by the email line lengths.

I just c&p. Let me send proper patch with description.

Thanks,
Michal

\
 
 \ /
  Last update: 2019-09-13 08:04    [W:0.074 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site