lkml.org 
[lkml]   [2019]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 2/4] null_blk: match the type of parameter nr_devices
Date
Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

On 09/13/2019 03:04 PM, André Almeida wrote:
> Since the variable nr_devices is an unsigned int, the module_param()
> should also use this type. Change the type so they can match.
>
> Signed-off-by: André Almeida <andrealmeid@collabora.com>
> Fixes: f7c4ce890dd2 ("null_blk: validate the number of devices")
> ---
> Changes since v1:
> - Add "Fixes" tag
> ---
> drivers/block/null_blk_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c
> index be32cb5ed339..5d20d65041bd 100644
> --- a/drivers/block/null_blk_main.c
> +++ b/drivers/block/null_blk_main.c
> @@ -142,7 +142,7 @@ module_param_named(bs, g_bs, int, 0444);
> MODULE_PARM_DESC(bs, "Block size (in bytes)");
>
> static unsigned int nr_devices = 1;
> -module_param(nr_devices, int, 0444);
> +module_param(nr_devices, uint, 0444);
> MODULE_PARM_DESC(nr_devices, "Number of devices to register");
>
> static bool g_blocking;
>


\
 
 \ /
  Last update: 2019-09-14 00:16    [W:0.107 / U:6.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site