[lkml]   [2019]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v2 0/4] null_blk: fixes around nr_devices and log improvements

This patch series address feedback for a previous patch series sent by
me "docs: block: null_blk: enhance document style"[1].

First patch removes a restriction that prevents null_blk to load with
(nr_devices == 0). This restriction breaks applications, so it's a bug. I
have tested it running the kernel with `null_blk.nr_devices=0`.

In the previous series I have changed the type of var nr_devices, but I
forgot to change the type at module_param(). The second patch fix that.

The third patch uses a cleaver approach to make log messages consistent
using pr_fmt and the last one add a note on how to do that at the
coding style documentation.


Changes since v1:
- Add "Fixes" tag at [2/4]
- No more headers reordering at [3/4]
- Use #undef pr_fmt and KBUILD_MODNAME at [3/4] and [4/4]
- Replace "printk.h" for "kernel.h" at [4/4]

More details are provided at each patch changelog


André Almeida (4):
null_blk: do not fail the module load with zero devices
null_blk: match the type of parameter nr_devices
null_blk: format pr_* logs with pr_fmt
coding-style: add explanation about pr_fmt macro

Documentation/process/coding-style.rst | 10 +++++++++-
drivers/block/null_blk.h | 4 +++-
drivers/block/null_blk_main.c | 24 ++++++++++--------------
drivers/block/null_blk_zoned.c | 6 +++---
4 files changed, 25 insertions(+), 19 deletions(-)


 \ /
  Last update: 2019-09-14 00:05    [W:0.077 / U:7.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site