lkml.org 
[lkml]   [2019]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch.pl: Don't complain about nominal authors if there isn't one
From
Date
On Thu, 2019-09-12 at 16:55 -0400, Alan Stern wrote:
> checkpatch.pl shouldn't warn about a "Missing Signed-off-by: line by
> nominal patch author" if there is no nominal patch author. Without
> this change, checkpatch always gives me the following warning:
>
> WARNING: Missing Signed-off-by: line by nominal patch author ''

When/how does this occur? Example please.

> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
>
> ---
>
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: usb-devel/scripts/checkpatch.pl
> ===================================================================
> --- usb-devel.orig/scripts/checkpatch.pl
> +++ usb-devel/scripts/checkpatch.pl
> @@ -6673,7 +6673,7 @@ sub process {
> if ($signoff == 0) {
> ERROR("MISSING_SIGN_OFF",
> "Missing Signed-off-by: line(s)\n");
> - } elsif (!$authorsignoff) {
> + } elsif ($author ne '' && !$authorsignoff) {
> WARN("NO_AUTHOR_SIGN_OFF",
> "Missing Signed-off-by: line by nominal patch author '$author'\n");
> }
>

\
 
 \ /
  Last update: 2019-09-12 23:09    [W:0.062 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site