lkml.org 
[lkml]   [2019]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] PTP: introduce new versions of IOCTLs
On Mon, Sep 09, 2019 at 10:59:39AM +0300, Felipe Balbi wrote:

> case PTP_PEROUT_REQUEST:
> + case PTP_PEROUT_REQUEST2:

...

> + if (((req.perout.flags & ~PTP_PEROUT_VALID_FLAGS) ||
> + req.perout.rsv[0] || req.perout.rsv[1] ||
> + req.perout.rsv[2] || req.perout.rsv[3]) &&
> + cmd == PTP_PEROUT_REQUEST2) {
> + err = -EINVAL;
> + break;

...

> +/*
> + * Bits of the ptp_perout_request.flags field:
> + */
> +#define PTP_PEROUT_VALID_FLAGS (~0)

I think you meant (0) here, or I am confused...

Thanks,
Richard

\
 
 \ /
  Last update: 2019-09-10 17:47    [W:0.076 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site