[lkml]   [2019]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v8 3/7] swiotlb: Zero out bounce buffer for untrusted device
Hi Christoph,

On 8/30/19 3:31 PM, Christoph Hellwig wrote:
> On Fri, Aug 30, 2019 at 03:17:14PM +0800, Lu Baolu wrote:
>> +#include <linux/pci.h>
>> + if (dev_is_untrusted(hwdev) && zero_size)
>> + memset(zero_addr, 0, zero_size);
> As said before swiotlb must not grow pci dependencies like this.

I understand your concern. I will try to remove this dependency in the
next version.

> Please move the untrusted flag to struct device.

The untrusted flag is introduced in another series. I agree that we
could consider to move it to struct device, but I think making it
in a separated patch looks better.

Best regards,
Lu Baolu

 \ /
  Last update: 2019-09-02 04:01    [W:0.073 / U:1.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site