lkml.org 
[lkml]   [2019]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] objtool,perf: Use shared x86 insn decoder
On Thu, 29 Aug 2019 17:41:17 -0500
Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> It's kind of silly that we have *three* identical copies of the x86 insn
> decoder in the kernel tree. Make it approximately 50% less silly by
> reducing that number to two.
>

Sounds good to me ;)

Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks,

> Josh Poimboeuf (4):
> objtool: Move x86 insn decoder to a common location
> perf: Update .gitignore file
> perf intel-pt: Remove inat.c from build dependency list
> perf intel-pt: Use shared x86 insn decoder
>
> .../{objtool => }/arch/x86/include/asm/inat.h | 0
> .../arch/x86/include/asm/inat_types.h | 0
> .../{objtool => }/arch/x86/include/asm/insn.h | 0
> .../arch/x86/include/asm/orc_types.h | 0
> tools/{objtool => }/arch/x86/lib/inat.c | 0
> tools/{objtool => }/arch/x86/lib/insn.c | 0
> .../arch/x86/lib/x86-opcode-map.txt | 0
> .../arch/x86/tools/gen-insn-attr-x86.awk | 0
> tools/objtool/Makefile | 4 +-
> tools/objtool/arch/x86/Build | 4 +-
> tools/objtool/arch/x86/decode.c | 4 +-
> tools/objtool/sync-check.sh | 12 +-
> tools/perf/.gitignore | 3 +
> tools/perf/arch/x86/tests/insn-x86.c | 2 +-
> tools/perf/arch/x86/util/archinsn.c | 2 +-
> tools/perf/check-headers.sh | 11 +-
> tools/perf/util/intel-pt-decoder/Build | 22 +-
> .../intel-pt-decoder/gen-insn-attr-x86.awk | 392 ------
> tools/perf/util/intel-pt-decoder/inat.c | 82 --
> tools/perf/util/intel-pt-decoder/inat.h | 230 ----
> tools/perf/util/intel-pt-decoder/inat_types.h | 15 -
> tools/perf/util/intel-pt-decoder/insn.c | 593 ---------
> tools/perf/util/intel-pt-decoder/insn.h | 216 ----
> .../intel-pt-decoder/intel-pt-insn-decoder.c | 10 +-
> .../util/intel-pt-decoder/x86-opcode-map.txt | 1072 -----------------
> 25 files changed, 34 insertions(+), 2640 deletions(-)
> rename tools/{objtool => }/arch/x86/include/asm/inat.h (100%)
> rename tools/{objtool => }/arch/x86/include/asm/inat_types.h (100%)
> rename tools/{objtool => }/arch/x86/include/asm/insn.h (100%)
> rename tools/{objtool => }/arch/x86/include/asm/orc_types.h (100%)
> rename tools/{objtool => }/arch/x86/lib/inat.c (100%)
> rename tools/{objtool => }/arch/x86/lib/insn.c (100%)
> rename tools/{objtool => }/arch/x86/lib/x86-opcode-map.txt (100%)
> rename tools/{objtool => }/arch/x86/tools/gen-insn-attr-x86.awk (100%)
> delete mode 100644 tools/perf/util/intel-pt-decoder/gen-insn-attr-x86.awk
> delete mode 100644 tools/perf/util/intel-pt-decoder/inat.c
> delete mode 100644 tools/perf/util/intel-pt-decoder/inat.h
> delete mode 100644 tools/perf/util/intel-pt-decoder/inat_types.h
> delete mode 100644 tools/perf/util/intel-pt-decoder/insn.c
> delete mode 100644 tools/perf/util/intel-pt-decoder/insn.h
> delete mode 100644 tools/perf/util/intel-pt-decoder/x86-opcode-map.txt
>
> --
> 2.20.1
>


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2019-08-30 17:21    [W:0.115 / U:41.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site