lkml.org 
[lkml]   [2019]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 01/10] software node: Get reference to parent swnode in get_parent op
On Thu, Aug 29, 2019 at 01:10:34PM +0300, Sakari Ailus wrote:
> The software_node_get_parent() returned a pointer to the parent swnode,
> but did not take a reference to it, leading the caller to put a reference
> that was not taken. Take that reference now.
>
> Fixes: 59abd83672f7 ("drivers: base: Introducing software nodes to the
> firmware node framework")

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/base/swnode.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
> index e7b3aa3bd55ad..a7cb41812cfda 100644
> --- a/drivers/base/swnode.c
> +++ b/drivers/base/swnode.c
> @@ -520,7 +520,10 @@ software_node_get_parent(const struct fwnode_handle *fwnode)
> {
> struct swnode *swnode = to_swnode(fwnode);
>
> - return swnode ? (swnode->parent ? &swnode->parent->fwnode : NULL) : NULL;
> + if (!swnode || !swnode->parent)
> + return NULL;
> +
> + return fwnode_handle_get(&swnode->parent->fwnode);
> }
>
> static struct fwnode_handle *
> --
> 2.20.1
>

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2019-08-30 14:33    [W:0.134 / U:1.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site