lkml.org 
[lkml]   [2019]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] staging: rts5208: Fix checkpath warning
From
Date
On Sat, 2019-08-31 at 07:55 +0530, P SAI PRASANTH wrote:
> This patch fixes the following checkpath warning
> in the file drivers/staging/rts5208/rtsx_transport.c:546
>
> WARNING: line over 80 characters
> + option = RTSX_SG_VALID | RTSX_SG_END |
> RTSX_SG_TRANS_DATA;
[]
> diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
[]
> @@ -540,11 +540,10 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card,
>
> dev_dbg(rtsx_dev(chip), "DMA addr: 0x%x, Len: 0x%x\n",
> (unsigned int)addr, len);
> -
> +

This same line delete then insert the same blank line
is very unusual.

What did you use to create this patch?

> + option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
> if (j == (sg_cnt - 1))
> - option = RTSX_SG_VALID | RTSX_SG_END | RTSX_SG_TRANS_DATA;
> - else
> - option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
> + option |= RTSX_SG_END;
>
> rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option);
>

\
 
 \ /
  Last update: 2019-08-31 04:58    [W:0.052 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site