lkml.org 
[lkml]   [2019]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 1/2] x86/mm/pti: Handle unaligned address gracefully in pti_clone_pagetable()
From
Date
On 8/28/19 7:24 AM, Thomas Gleixner wrote:
> From: Song Liu <songliubraving@fb.com>
>
> pti_clone_pmds() assumes that the supplied address is either:
>
> - properly PUD/PMD aligned
> or
> - the address is actually mapped which means that independent
> of the mapping level (PUD/PMD/PTE) the next higher mapping
> exist.
>
> If that's not the case the unaligned address can be incremented by PUD or
> PMD size wrongly. All callers supply mapped and/or aligned addresses, but
> for robustness sake, it's better to handle that case proper and to emit a
> warning.

Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>

Song, did you ever root-cause the performance regression? I thought
there were still some mysteries there.

\
 
 \ /
  Last update: 2019-08-28 17:46    [W:0.175 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site