lkml.org 
[lkml]   [2019]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 01/14] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation
Hi Geert,

On Mon, Aug 26, 2019 at 09:34:41AM +0200, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> On Sun, Aug 25, 2019 at 3:50 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
> > Add device tree bindings documentation for the Renesas R-Car Display
> > Unit Color Management Module.
> >
> > CMM is the image enhancement module available on each R-Car DU video
> > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded).
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
>
> Thanks for your patch!
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/renesas,cmm.txt
> > @@ -0,0 +1,33 @@
> > +* Renesas R-Car Color Management Module (CMM)
> > +
> > +Renesas R-Car image enhancement module connected to R-Car DU video channels.
> > +
> > +Required properties:
> > + - compatible: shall be one or more of the following:
> > + - "renesas,cmm-r8a7795": for R8A7795 (R-Car H3) compatible CMM.
> > + - "renesas,cmm-r8a7796": for R8A7796 (R-Car M3-W) compatible CMM.
> > + - "renesas,cmm-r8a77965": for R8A77965 (R-Car M3-N) compatible CMM.
> > + - "renesas,cmm-r8a77990": for R8A77990 (R-Car E3) compatible CMM.
> > + - "renesas,cmm-r8a77995": for R8A77995 (R-Car D3) compatible CMM.
>
> Please use "renesas,<socype->-cmm" instead of "renesas,cmm-<soctype>".
>

I actually copied it from the r-car gpio bindings, and I liked
cmm-<soctype> better. If you prefer I can change it though.

> > + - "renesas,rcar-gen3-cmm": for a generic R-Car Gen3 compatible CMM.
> > + - "renesas,rcar-gen2-cmm": for a generic R-Car Gen2 compatible CMM.
> > +
> > + When the generic compatible string is specified, the SoC-specific
> > + version corresponding to the platform should be listed first.
> > +
> > + - reg: the address base and length of the memory area where CMM control
> > + registers are mapped to.
> > +
> > + - clocks: phandle and clock-specifier pair to the CMM functional clock
> > + supplier.
>
> Thinking about yaml validation:
>
> power-domains?
> resets?
>

They should indeed be documented.

Thanks
j

> > +Example:
> > +--------
> > +
> > + cmm0: cmm@fea40000 {
> > + compatible = "renesas,cmm-r8a7796";
> > + reg = <0 0xfea40000 0 0x1000>;
> > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> > + clocks = <&cpg CPG_MOD 711>;
> > + resets = <&cpg 711>;
> > + };
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-08-26 09:58    [W:0.119 / U:1.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site