lkml.org 
[lkml]   [2019]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/2] dt-bindings: phy: intel-emmc-phy: Add YAML schema for LGM eMMC PHY
From
Date
Hi Rob,

On 21/8/2019 9:35 PM, Rob Herring wrote:
> On Wed, Aug 21, 2019 at 5:11 AM Ramuthevar,Vadivel MuruganX
> <vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>
>> Add a YAML schema to use the host controller driver with the
>> eMMC PHY on Intel's Lightning Mountain SoC.
>>
>> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>> ---
>> changes in v3:
>> - resolve 'make dt_binding_check' warnings
>>
>> changes in v2:
>> As per Rob Herring review comments, the following updates
>> - change GPL-2.0 -> (GPL-2.0-only OR BSD-2-Clause)
>> - filename is the compatible string plus .yaml
>> - LGM: Lightning Mountain
>> - update maintainer
>> - add intel,syscon under property list
>> - keep one example instead of two
>> ---
>> .../bindings/phy/intel,lgm-emmc-phy.yaml | 59 ++++++++++++++++++++++
>> 1 file changed, 59 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
>> new file mode 100644
>> index 000000000000..9342e33d8b02
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
>> @@ -0,0 +1,59 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/phy/intel,lgm-emmc-phy.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Intel Lightning Mountain(LGM) eMMC PHY Device Tree Bindings
>> +
>> +maintainers:
>> + - Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>> +
>> +properties:
>> + "#phy-cells":
>> + const: 0
>> +
>> + compatible:
>> + const: intel,lgm-emmc-phy
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + syscon:
> intel,syscon like the example. You must have used 5.2 as on 5.3-rc the
> example will fail validation.
Thanks for the review comments,  used 5.3 for validation, after
addressing the below comments
once again validate on both 5.2 and 5.3 as well.
>> + items:
> Drop items as there is only 1.
agreed
>> + $ref: "/schemas/types.yaml#definitions/phandle"
>> +
>> + clocks:
>> + items:
>> + - description: e-MMC phy module clock
>> +
>> + clock-names:
>> + items:
>> + - const: emmcclk
>> +
>> + resets:
>> + maxItems: 1
>> +
>> +required:
>> + - "#phy-cells"
>> + - compatible
>> + - reg
>> + - clocks
>> + - clock-names
>> + - resets
>> + - ref
> Not documented.

Agreed, will update

With Best Regards
Vadivel
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + emmc_phy: emmc_phy {
>> + compatible = "intel,lgm-emmc-phy";
>> + reg = <0xe0020000 0x100>;
>> + intel,syscon = <&sysconf>;
>> + clocks = <&emmc>;
>> + clock-names = "emmcclk";
>> + #phy-cells = <0>;
>> + };
>> +
>> +...
>> --
>> 2.11.0
>>

\
 
 \ /
  Last update: 2019-08-22 07:44    [W:0.047 / U:2.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site