lkml.org 
[lkml]   [2019]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 10/11] mfd: cros_ec: Use mfd_add_hotplug_devices() helper
From
Date
Hi Lee,

On 12/8/19 9:24, Lee Jones wrote:
> On Mon, 22 Jul 2019, Enric Balletbo i Serra wrote:
>
>> Use mfd_add_hotplug_devices() helper to register the subdevices.
>
> You need to state why this change is useful/required.
>

The reason for this change is to avoid a bit of boiler plate and be coherent
with the new functions created to register subdevices, as Gwendal pointed to use
that. I'll make explicit in the commit comment on next version.

Thanks,
Enric

>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>> Tested-by: Gwendal Grignou <gwendal@chromium.org>
>> ---
>>
>> Changes in v5: None
>> Changes in v4: None
>> Changes in v3:
>> - Add a new patch to use mfd_add_hoplug_devices to register subdevices
>>
>> Changes in v2: None
>>
>> drivers/mfd/cros_ec_dev.c | 18 ++++++------------
>> 1 file changed, 6 insertions(+), 12 deletions(-)
>

\
 
 \ /
  Last update: 2019-08-21 19:50    [W:0.103 / U:1.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site