lkml.org 
[lkml]   [2019]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] cpustat: print watchdog time and statistics of soft and hard interrupts in soft lockup scenes
From
Date
Sorry, I cannot understand this problem accurately. I try to understand it and I guess what you want
to express is that the return value type should be cputime64_t but not u64, just like as follows:

+static cputime64_t cpustat_curr_cputime(int cpu, int index)
+{
+ cputime64_t time;
+
+ if (index == CPUTIME_IDLE)
+ time = get_idle_time(cpu);
+ else if (index == CPUTIME_IOWAIT)
+ time = get_iowait_time(cpu);

I don't know if I understand it correctly. Looking forward to your answer.




On 2019/8/20 19:04, Peter Zijlstra wrote:
> On Mon, Aug 19, 2019 at 03:12:24PM +0800, c00423981 wrote:
>> +static u64 cpustat_curr_cputime(int cpu, int index)
>> +{
>> + u64 time;
>> +
>> + if (index == CPUTIME_IDLE)
>> + time = get_idle_time(cpu);
>> + else if (index == CPUTIME_IOWAIT)
>> + time = get_iowait_time(cpu);
>
> NAK; don't add new users of this terminally broken interface.
>
>

\
 
 \ /
  Last update: 2019-08-21 10:35    [W:0.096 / U:4.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site