lkml.org 
[lkml]   [2019]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 03/44] posix-timer: Use a callback for cancel synchronization
On Mon, 19 Aug 2019, Christoph Hellwig wrote:

> > + if (!WARN_ON_ONCE(kc->timer_wait_running))
> > + kc->timer_wait_running(timer);
>
> This looks weird. The only place calling yor new method only does so
> after checking that it is not set and actually warns if it set?

Yeah, that wants to be;

if (!WARN_ON_ONCE(!kc->timer_wait_running))
kc->timer_wait_running(timer);

\
 
 \ /
  Last update: 2019-08-20 15:09    [W:0.087 / U:9.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site