lkml.org 
[lkml]   [2019]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 00/20] vfs: Add support for timestamp limits
From
Date
On Sun, 2019-08-18 at 09:57 -0700, Deepa Dinamani wrote:
> The series is an update and a more complete version of the
> previously posted series at
> https://lore.kernel.org/linux-fsdevel/20180122020426.2988-1-deepa.kernel@gmail.com/
>
> Thanks to Arnd Bergmann for doing a few preliminary reviews.
> They helped me fix a few issues I had overlooked.
>
> The limits (sometimes granularity also) for the filesystems updated here are according to the
> following table:
>
> File system Time type Start year Expiration year Granularity
> cramfs fixed 0 0
> romfs fixed 0 0
> pstore ascii seconds (27 digit ascii) S64_MIN S64_MAX 1
> coda INT64 S64_MIN S64_MAX 1
> omfs 64-bit milliseconds 0 U64_MAX/ 1000 NSEC_PER_MSEC
> befs unsigned 48-bit seconds 0 0xffffffffffff alloc_super
> bfs unsigned 32-bit seconds 0 U32_MAX alloc_super
> efs unsigned 32-bit seconds 0 U32_MAX alloc_super
> ext2 signed 32-bit seconds S32_MIN S32_MAX alloc_super
> ext3 signed 32-bit seconds S32_MIN S32_MAX alloc_super
> ext4 (old) signed 32-bit seconds S32_MIN S32_MAX alloc_super
> ext4 (extra) 34-bit seconds, 30-bit ns S32_MIN 0x37fffffff 1
> freevxfs u32 secs/usecs 0 U32_MAX alloc_super
> jffs2 unsigned 32-bit seconds 0 U32_MAX alloc_super
> jfs unsigned 32-bit seconds/ns 0 U32_MAX 1
> minix unsigned 32-bit seconds 0 U32_MAX alloc_super
> orangefs u64 seconds 0 U64_MAX alloc_super
> qnx4 unsigned 32-bit seconds 0 U32_MAX alloc_super
> qnx6 unsigned 32-bit seconds 0 U32_MAX alloc_super
> reiserfs unsigned 32-bit seconds 0 U32_MAX alloc_super
> squashfs unsigned 32-bit seconds 0 U32_MAX alloc_super
> ufs1 signed 32-bit seconds S32_MIN S32_MAX NSEC_PER_SEC
> ufs2 signed 64-bit seconds/u32 ns S64_MIN S64_MAX 1
> xfs signed 32-bit seconds/ns S32_MIN S32_MAX 1
> ceph unsigned 32-bit second/ns 0 U32_MAX 1000

Looks reasonable, overall.

Note that the granularity changed recently for cephfs. See commit
0f7cf80ae96c2a (ceph: initialize superblock s_time_gran to 1).

In any case, you can add my Acked-by

--
Jeff Layton <jlayton@kernel.org>

\
 
 \ /
  Last update: 2019-08-20 13:07    [W:0.137 / U:2.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site