lkml.org 
[lkml]   [2019]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] bug: Move WARN_ON() "cut here" into exception handler
On Tue, 20 Aug 2019 12:58:49 +0200
Christophe Leroy <christophe.leroy@c-s.fr> wrote:

> >> index 1077366f496b..6c22e8a6f9de 100644
> >> --- a/lib/bug.c
> >> +++ b/lib/bug.c
> >> @@ -181,6 +181,15 @@ enum bug_trap_type report_bug(unsigned long bugaddr, struct pt_regs *regs)
> >> }
> >> }
> >>
> >> + /*
> >> + * BUG() and WARN_ON() families don't print a custom debug message
> >> + * before triggering the exception handler, so we must add the
> >> + * "cut here" line now. WARN() issues its own "cut here" before the
> >> + * extra debugging message it writes before triggering the handler.
> >> + */
> >> + if ((bug->flags & BUGFLAG_PRINTK) == 0)
> >> + printk(KERN_DEFAULT CUT_HERE);
> >
> > I'm not loving that BUGFLAG_PRINTK name, BUGFLAG_CUT_HERE makes more
> > sense to me.
> >
>
> Actually it would be BUGFLAG_NO_CUT_HERE then, otherwise all arches not
> using the generic macros will have to add the flag to get the "cut here"
> line.
>

Perhaps they all should be audited to see if they don't have the same
problem?

-- Steve

\
 
 \ /
  Last update: 2019-08-21 03:21    [W:0.082 / U:1.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site