lkml.org 
[lkml]   [2019]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] cpufreq: schedutil: fix equation in comment
On Fri, 2 Aug 2019 at 12:46, Qais Yousef <qais.yousef@arm.com> wrote:
>
> scale_irq_capacity() call in schedutil_cpu_util() does
>
> util *= (max - irq)
> util /= max
>
> But the comment says
>
> util *= (1 - irq)
> util /= max
>
> Fix the comment to match what the scaling function does.
>
> Signed-off-by: Qais Yousef <qais.yousef@arm.com>

FWIW
Acked-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> kernel/sched/cpufreq_schedutil.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> index 636ca6f88c8e..e127d89d5974 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -259,9 +259,9 @@ unsigned long schedutil_cpu_util(int cpu, unsigned long util_cfs,
> * irq metric. Because IRQ/steal time is hidden from the task clock we
> * need to scale the task numbers:
> *
> - * 1 - irq
> - * U' = irq + ------- * U
> - * max
> + * max - irq
> + * U' = irq + --------- * U
> + * max
> */
> util = scale_irq_capacity(util, irq, max);
> util += irq;
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2019-08-02 15:20    [W:0.119 / U:2.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site