lkml.org 
[lkml]   [2019]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build
From
Date
Hi Guido, Fabio,

On Fri, 2019-08-02 at 08:03 -0300, Fabio Estevam wrote:
> Hi Guido,
>
> Good catch!
>
> On Fri, Aug 2, 2019 at 7:55 AM Guido Günther <agx@sigxcpu.org> wrote:
> >
> > Since
> >
> > commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
> >
> > imx-ipuv3-crtc.o is built via imxdrm-objs. So there's no need to keep an
>
> Actually, it is ipuv3-crtc.o that is built via imxdrm-objs, not
> imx-ipuv3-crtc.o.
>
> Apart from that:
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

Thank you, applied to imx-drm/next with Fabio's R-b, and added Fixes:
tag, and the commit message changed as follows:

    drm/imx: Drop unused imx-ipuv3-crtc.o build
    
    Since
    
    commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
    
    the former contents of imx-ipuv3-crtc.o are built via imxdrm-objs. So
    there's no need to keep an extra entry with a non existing config value
    (CONFIG_DRM_IMX_IPUV3).
    
    Fixes: 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
    Signed-off-by: Guido Günther <agx@sigxcpu.org>
    Reviewed-by: Fabio Estevam <festevam@gmail.com>
    Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

no action necessary if you agree, otherwise just send a v2 and I'll
replace it.

regards
Philipp

\
 
 \ /
  Last update: 2019-08-02 14:05    [W:0.039 / U:1.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site