lkml.org 
[lkml]   [2019]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Possible mem cgroup bug in kernels between 4.18.0 and 5.3-rc1.
[Hillf, your email client or workflow mangles emails. In this case you
are seem to be reusing the message id from the email you are replying to
which confuses my email client to assume your email is a duplicate.]

On Fri 02-08-19 16:08:01, Hillf Danton wrote:
[...]
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -2547,8 +2547,12 @@ retry:
> nr_reclaimed = try_to_free_mem_cgroup_pages(mem_over_limit, nr_pages,
> gfp_mask, may_swap);
>
> - if (mem_cgroup_margin(mem_over_limit) >= nr_pages)
> - goto retry;
> + if (mem_cgroup_margin(mem_over_limit) >= nr_pages) {
> + if (nr_retries--)
> + goto retry;
> + /* give up charging memhog */
> + return -ENOMEM;
> + }

Huh, what? You are effectively saying that we should fail the charge
when the requested nr_pages would fit in. This doesn't make much sense
to me. What are you trying to achive here?
--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2019-08-02 10:18    [W:0.062 / U:9.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site