lkml.org 
[lkml]   [2019]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] video: fbdev: omapfb_main: Mark expected switch fall-throughs
On Fri, Aug 02, 2019 at 02:15:42PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning (Building: omap1_defconfig arm):
>
> drivers/video/fbdev/omap/omapfb_main.c:449:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/video/fbdev/omap/omapfb_main.c:1549:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/video/fbdev/omap/omapfb_main.c:1547:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/video/fbdev/omap/omapfb_main.c:1545:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/video/fbdev/omap/omapfb_main.c:1543:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/video/fbdev/omap/omapfb_main.c:1540:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/video/fbdev/omap/omapfb_main.c:1538:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/video/fbdev/omap/omapfb_main.c:1535:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
> drivers/video/fbdev/omap/omapfb_main.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
> index 90eca64e3144..702cca59bda1 100644
> --- a/drivers/video/fbdev/omap/omapfb_main.c
> +++ b/drivers/video/fbdev/omap/omapfb_main.c
> @@ -447,6 +447,7 @@ static int set_color_mode(struct omapfb_plane_struct *plane,
> return 0;
> case 12:
> var->bits_per_pixel = 16;
> + /* fall through */
> case 16:
> if (plane->fbdev->panel->bpp == 12)
> plane->color_mode = OMAPFB_COLOR_RGB444;
> @@ -1534,20 +1535,27 @@ static void omapfb_free_resources(struct omapfb_device *fbdev, int state)
> case OMAPFB_ACTIVE:
> for (i = 0; i < fbdev->mem_desc.region_cnt; i++)
> unregister_framebuffer(fbdev->fb_info[i]);
> + /* fall through */
> case 7:
> omapfb_unregister_sysfs(fbdev);
> + /* fall through */
> case 6:
> if (fbdev->panel->disable)
> fbdev->panel->disable(fbdev->panel);
> + /* fall through */
> case 5:
> omapfb_set_update_mode(fbdev, OMAPFB_UPDATE_DISABLED);
> + /* fall through */
> case 4:
> planes_cleanup(fbdev);
> + /* fall through */
> case 3:
> ctrl_cleanup(fbdev);
> + /* fall through */
> case 2:
> if (fbdev->panel->cleanup)
> fbdev->panel->cleanup(fbdev->panel);
> + /* fall through */
> case 1:
> dev_set_drvdata(fbdev->dev, NULL);
> kfree(fbdev);
> --
> 2.22.0
>

--
Kees Cook

\
 
 \ /
  Last update: 2019-08-03 04:29    [W:0.034 / U:6.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site