lkml.org 
[lkml]   [2019]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH net-next v2] net: phy: broadcom: add 1000Base-X support for BCM54616S
Date
On 8/2/19 7:50 AM, Andrew Lunn wrote:
>> +static int bcm54616s_read_status(struct phy_device *phydev)
>> +{
>> + int err;
>> +
>> + err = genphy_read_status(phydev);
>> +
>> + /* 1000Base-X register set doesn't provide speed fields: the
>> + * link speed is always 1000 Mb/s as long as link is up.
>> + */
>> + if (phydev->dev_flags & PHY_BCM_FLAGS_MODE_1000BX &&
>> + phydev->link)
>> + phydev->speed = SPEED_1000;
>> +
>> + return err;
>> +}
>
> This function is equivalent to bcm5482_read_status(). You should use
> it, rather than add a new function.

Thank you for pointing it out. Will fix the code.

BTW, should I update the patch subject to something more descriptive (such as "net: phy: broadcom: fix BCM54616S read_status in 1000X mode")? Or I should use the same title to avoid confusion?


Thanks,

Tao
\
 
 \ /
  Last update: 2019-08-02 21:53    [W:0.054 / U:2.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site